Closed Bug 1857746 Opened 2 years ago Closed 2 years ago

Downscaler.cpp: using "std:max" is unused

Categories

(Core :: Graphics: ImageLib, task)

task

Tracking

()

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: Sylvestre, Assigned: knowlden887, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=c++])

Attachments

(2 files)

if you call using std::max, you don't need a using std::max;

hello , I am new to this community and an outreachy applicant. Can I take up this issue to get started?

Sure, just submit a patch :)

Attached image Downscaler cpp.png

The bug in this code provides learners with a way to learn more about code workflows. The link that contains the bug is given here: https://searchfox.org/mozilla-central/source/image/Downscaler.cpp#14 It requires contributors to remove the 'using std::max;' line since the function is used directly without the need for the using declaration. By taking off the line, the code's readability is improved.

Flags: needinfo?(sledru)

Same comment as in bug 1856240
Please Just focus on one bug. Leave the others to other beginners

Flags: needinfo?(sledru)
Assignee: nobody → knowlden887
Status: NEW → ASSIGNED
Attachment #9360901 - Attachment description: Bug 1857746 - Remove std max in downscaler. r=Sylvestre! → Bug 1857746 - Remove std max in downscaler. r=sylvestre!

I am sorry, I didn't know I have to focus on only one contribution. Based on the Outreachy webinars I attended, the recommendation was to have at least one contribution but to opt for as many contributions as possible in the same community.

Flags: needinfo?(sledru)

Needinfo should be used only when you need an answer. Please use it wisely

Yes for contributing as much as possible but please work on harder issues.

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fede12cd5923 Remove std max in downscaler. r=sylvestre DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: