Downscaler.cpp: using "std:max" is unused
Categories
(Core :: Graphics: ImageLib, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox121 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: knowlden887, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=c++])
Attachments
(2 files)
Filling as a good first bug to learn workflows.
https://searchfox.org/mozilla-central/source/image/Downscaler.cpp#14
using decl 'max' is unused
(it is used directly as std::max)
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Comment 1•2 years ago
|
||
Reporter | ||
Comment 2•2 years ago
|
||
if you call using std::max, you don't need a using std::max;
hello , I am new to this community and an outreachy applicant. Can I take up this issue to get started?
Reporter | ||
Comment 4•2 years ago
|
||
Sure, just submit a patch :)
Comment 5•2 years ago
|
||
The bug in this code provides learners with a way to learn more about code workflows. The link that contains the bug is given here: https://searchfox.org/mozilla-central/source/image/Downscaler.cpp#14 It requires contributors to remove the 'using std::max;' line since the function is used directly without the need for the using declaration. By taking off the line, the code's readability is improved.
Reporter | ||
Comment 6•2 years ago
|
||
Same comment as in bug 1856240
Please Just focus on one bug. Leave the others to other beginners
Assignee | ||
Comment 7•2 years ago
|
||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 8•2 years ago
|
||
I am sorry, I didn't know I have to focus on only one contribution. Based on the Outreachy webinars I attended, the recommendation was to have at least one contribution but to opt for as many contributions as possible in the same community.
Reporter | ||
Comment 9•2 years ago
|
||
Needinfo should be used only when you need an answer. Please use it wisely
Yes for contributing as much as possible but please work on harder issues.
Comment 10•2 years ago
|
||
Comment 11•2 years ago
|
||
bugherder |
Description
•